From 95e9da42d6adac01260bfcfb13d44f5baacc4d2f Mon Sep 17 00:00:00 2001
From: Soulter <37870767+Soulter@users.noreply.github.com>
Date: Sun, 23 Nov 2025 22:03:07 +0800
Subject: [PATCH] fix(webchat): webchat session cannot be deleted (#3759)

---
 astrbot/core/db/po.py                               |  2 +-
 astrbot/core/db/sqlite.py                           |  4 ++--
 .../src/components/chat/ConversationSidebar.vue     | 13 ++++++++++---
 dashboard/src/i18n/locales/en-US/features/chat.json |  3 ++-
 dashboard/src/i18n/locales/zh-CN/features/chat.json |  3 ++-
 5 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/astrbot/core/db/po.py b/astrbot/core/db/po.py
index d6621d072..3d9947413 100644
--- a/astrbot/core/db/po.py
+++ b/astrbot/core/db/po.py
@@ -173,7 +173,7 @@ class PlatformSession(SQLModel, table=True):
         max_length=100,
         nullable=False,
         unique=True,
-        default_factory=lambda: f"webchat_{uuid.uuid4()}",
+        default_factory=lambda: str(uuid.uuid4()),
     )
     platform_id: str = Field(default="webchat", nullable=False)
     """Platform identifier (e.g., 'webchat', 'qq', 'discord')"""
diff --git a/astrbot/core/db/sqlite.py b/astrbot/core/db/sqlite.py
index 194618612..276f5821f 100644
--- a/astrbot/core/db/sqlite.py
+++ b/astrbot/core/db/sqlite.py
@@ -794,7 +794,7 @@ class SQLiteDatabase(BaseDatabase):
 
                 await session.execute(
                     update(PlatformSession)
-                    .where(col(PlatformSession.session_id == session_id))
+                    .where(col(PlatformSession.session_id) == session_id)
                     .values(**values),
                 )
 
@@ -805,6 +805,6 @@ class SQLiteDatabase(BaseDatabase):
             async with session.begin():
                 await session.execute(
                     delete(PlatformSession).where(
-                        col(PlatformSession.session_id == session_id),
+                        col(PlatformSession.session_id) == session_id,
                     ),
                 )
diff --git a/dashboard/src/components/chat/ConversationSidebar.vue b/dashboard/src/components/chat/ConversationSidebar.vue
index 5abc1bed8..062588854 100644
--- a/dashboard/src/components/chat/ConversationSidebar.vue
+++ b/dashboard/src/components/chat/ConversationSidebar.vue
@@ -64,7 +64,7 @@
                                     @click.stop="$emit('editTitle', item.session_id, item.display_name)" />
                                 <v-btn icon="mdi-delete" size="x-small" variant="text"
                                     class="delete-conversation-btn" color="error"
-                                    @click.stop="$emit('deleteConversation', item.session_id)" />
+                                    @click.stop="handleDeleteConversation(item)" />
                             </div>
                         </template>
                     </v-list-item>
@@ -85,7 +85,7 @@
 
 <script setup lang="ts">
 import { ref } from 'vue';
-import { useI18n, useModuleI18n } from '@/i18n/composables';
+import { useModuleI18n } from '@/i18n/composables';
 import type { Session } from '@/composables/useSessions';
 
 interface Props {
@@ -109,7 +109,6 @@ const emit = defineEmits<{
 }>();
 
 const { tm } = useModuleI18n('features/chat');
-const { t } = useI18n();
 
 const sidebarCollapsed = ref(true);
 const sidebarHovered = ref(false);
@@ -159,6 +158,14 @@ function handleSidebarMouseLeave() {
     }
     sidebarHoverExpanded.value = false;
 }
+
+function handleDeleteConversation(session: Session) {
+    const sessionTitle = session.display_name || tm('conversation.newConversation');
+    const message = tm('conversation.confirmDelete', { name: sessionTitle });
+    if (window.confirm(message)) {
+        emit('deleteConversation', session.session_id);
+    }
+}
 </script>
 
 <style scoped>
diff --git a/dashboard/src/i18n/locales/en-US/features/chat.json b/dashboard/src/i18n/locales/en-US/features/chat.json
index bc83787ff..85c97647c 100644
--- a/dashboard/src/i18n/locales/en-US/features/chat.json
+++ b/dashboard/src/i18n/locales/en-US/features/chat.json
@@ -51,7 +51,8 @@
     "editDisplayName": "Edit Session Name",
     "displayName": "Session Name",
     "displayNameUpdated": "Session name updated",
-    "displayNameUpdateFailed": "Failed to update session name"
+    "displayNameUpdateFailed": "Failed to update session name",
+    "confirmDelete": "Are you sure you want to delete \"{name}\"? This action cannot be undone."
   },
   "modes": {
     "darkMode": "Switch to Dark Mode",
diff --git a/dashboard/src/i18n/locales/zh-CN/features/chat.json b/dashboard/src/i18n/locales/zh-CN/features/chat.json
index 002ea626e..e543b5472 100644
--- a/dashboard/src/i18n/locales/zh-CN/features/chat.json
+++ b/dashboard/src/i18n/locales/zh-CN/features/chat.json
@@ -51,7 +51,8 @@
     "editDisplayName": "编辑会话名称",
     "displayName": "会话名称",
     "displayNameUpdated": "会话名称已更新",
-    "displayNameUpdateFailed": "更新会话名称失败"
+    "displayNameUpdateFailed": "更新会话名称失败",
+    "confirmDelete": "确定要删除“{name}”吗？此操作无法撤销。"
   },
   "modes": {
     "darkMode": "切换到夜间模式",