misskey/packages/client/src/ui
Johann150 804fa33535
refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
..
_common_ fix lints (#8737) 2022-05-26 22:53:09 +09:00
deck refactor: improve code quality (#8751) 2022-05-29 15:15:52 +09:00
visitor disable animations on more transitions (#8112) 2022-01-25 23:18:21 +09:00
classic.header.vue refactor: use Vite to build instead of webpack (#8575) 2022-05-01 22:51:07 +09:00
classic.side.vue fix: Fix Sideview (#8235) 2022-02-01 23:48:19 +09:00
classic.sidebar.vue refactor: use Vite to build instead of webpack (#8575) 2022-05-01 22:51:07 +09:00
classic.vue disable animations on more transitions (#8112) 2022-01-25 23:18:21 +09:00
classic.widgets.vue fix lints (#8737) 2022-05-26 22:53:09 +09:00
deck.vue enhance: タッチパッド・タッチスクリーンでのデッキの操作性を向上 (#8450) 2022-04-02 15:12:01 +09:00
desktop.vue refactoring 2021-11-12 02:02:25 +09:00
universal.vue fix: iPhone X以降(?)でページの内容が全て表示しきれないのを修正 (#8375) 2022-03-05 02:00:45 +09:00
universal.widgets.vue feat(tests): add e2e tests for widgets (#8735) 2022-05-28 14:28:12 +09:00
visitor.vue refactoring 2021-11-12 02:02:25 +09:00
zen.vue fix(client): タイムラインのkeep-aliveが効かなくなっているのを修正 2022-01-21 21:47:36 +09:00