* perf(backend): avoid N+1 selects from `user` table when packing many entities * perf(backend): use `packMany` instead of mapping to `pack`
105 lines
2.9 KiB
TypeScript
105 lines
2.9 KiB
TypeScript
/*
|
|
* SPDX-FileCopyrightText: syuilo and misskey-project
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
|
|
import { Inject, Injectable } from '@nestjs/common';
|
|
import { Brackets } from 'typeorm';
|
|
import type { RoleAssignmentsRepository, RolesRepository } from '@/models/_.js';
|
|
import { Endpoint } from '@/server/api/endpoint-base.js';
|
|
import { QueryService } from '@/core/QueryService.js';
|
|
import { DI } from '@/di-symbols.js';
|
|
import { UserEntityService } from '@/core/entities/UserEntityService.js';
|
|
import { ApiError } from '../../error.js';
|
|
|
|
export const meta = {
|
|
tags: ['role', 'users'],
|
|
|
|
requireCredential: false,
|
|
|
|
errors: {
|
|
noSuchRole: {
|
|
message: 'No such role.',
|
|
code: 'NO_SUCH_ROLE',
|
|
id: '30aaaee3-4792-48dc-ab0d-cf501a575ac5',
|
|
},
|
|
},
|
|
|
|
res: {
|
|
type: 'array',
|
|
items: {
|
|
type: 'object',
|
|
nullable: false,
|
|
properties: {
|
|
id: {
|
|
type: 'string',
|
|
format: 'misskey:id',
|
|
},
|
|
user: {
|
|
type: 'object',
|
|
ref: 'UserDetailed',
|
|
},
|
|
},
|
|
required: ['id', 'user'],
|
|
},
|
|
},
|
|
} as const;
|
|
|
|
export const paramDef = {
|
|
type: 'object',
|
|
properties: {
|
|
roleId: { type: 'string', format: 'misskey:id' },
|
|
sinceId: { type: 'string', format: 'misskey:id' },
|
|
untilId: { type: 'string', format: 'misskey:id' },
|
|
limit: { type: 'integer', minimum: 1, maximum: 100, default: 10 },
|
|
},
|
|
required: ['roleId'],
|
|
} as const;
|
|
|
|
@Injectable()
|
|
export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-disable-line import/no-default-export
|
|
constructor(
|
|
@Inject(DI.rolesRepository)
|
|
private rolesRepository: RolesRepository,
|
|
|
|
@Inject(DI.roleAssignmentsRepository)
|
|
private roleAssignmentsRepository: RoleAssignmentsRepository,
|
|
|
|
private queryService: QueryService,
|
|
private userEntityService: UserEntityService,
|
|
) {
|
|
super(meta, paramDef, async (ps, me) => {
|
|
const role = await this.rolesRepository.findOneBy({
|
|
id: ps.roleId,
|
|
isPublic: true,
|
|
isExplorable: true,
|
|
});
|
|
|
|
if (role == null) {
|
|
throw new ApiError(meta.errors.noSuchRole);
|
|
}
|
|
|
|
const query = this.queryService.makePaginationQuery(this.roleAssignmentsRepository.createQueryBuilder('assign'), ps.sinceId, ps.untilId)
|
|
.andWhere('assign.roleId = :roleId', { roleId: role.id })
|
|
.andWhere(new Brackets(qb => {
|
|
qb
|
|
.where('assign.expiresAt IS NULL')
|
|
.orWhere('assign.expiresAt > :now', { now: new Date() });
|
|
}))
|
|
.innerJoinAndSelect('assign.user', 'user');
|
|
|
|
const assigns = await query
|
|
.limit(ps.limit)
|
|
.getMany();
|
|
|
|
const _users = assigns.map(({ user, userId }) => user ?? userId);
|
|
const _userMap = await this.userEntityService.packMany(_users, me, { schema: 'UserDetailed' })
|
|
.then(users => new Map(users.map(u => [u.id, u])));
|
|
return await Promise.all(assigns.map(async assign => ({
|
|
id: assign.id,
|
|
user: _userMap.get(assign.userId) ?? await this.userEntityService.pack(assign.user!, me, { schema: 'UserDetailed' }),
|
|
})));
|
|
});
|
|
}
|
|
}
|