From 36fcad03c546c799614c9416bf9d6c59724c4ca5 Mon Sep 17 00:00:00 2001
From: 0xYYBB | ZYY | Bobo <128128010+the-dev-z@users.noreply.github.com>
Date: Sun, 16 Nov 2025 08:26:12 +0800
Subject: [PATCH] =?UTF-8?q?fix(docker):=20revert=20healthcheck=20to=20wget?=
 =?UTF-8?q?=20for=20Alpine=20compatibility=20(#986)=20##=20Problem=20PR=20?=
 =?UTF-8?q?#906=20changed=20healthcheck=20commands=20from=20`wget`=20to=20?=
 =?UTF-8?q?`curl`,=20but=20Alpine=20Linux=20(our=20base=20image)=20does=20?=
 =?UTF-8?q?not=20include=20`curl`=20by=20default,=20causing=20all=20contai?=
 =?UTF-8?q?ners=20to=20fail=20healthchecks=20with:=20```=20exec:=20"curl":?=
 =?UTF-8?q?=20executable=20file=20not=20found=20in=20$PATH=20```=20This=20?=
 =?UTF-8?q?creates=20a=20configuration=20mismatch:=20-=20docker/Dockerfile?=
 =?UTF-8?q?.backend=20uses=20`wget`=20(=E2=9C=85=20works)=20-=20docker-com?=
 =?UTF-8?q?pose.yml=20uses=20`curl`=20(=E2=9D=8C=20fails)=20##=20Root=20Ca?=
 =?UTF-8?q?use=20Analysis=20Alpine=20Linux=20philosophy=20is=20minimalism:?=
 =?UTF-8?q?=20-=20=E2=9C=85=20`wget`=20is=20pre-installed=20(part=20of=20b?=
 =?UTF-8?q?usybox)=20-=20=E2=9D=8C=20`curl`=20requires=20`apk=20add=20curl?=
 =?UTF-8?q?`=20(~3MB=20extra)=20The=20original=20PR=20#906=20made=20two=20?=
 =?UTF-8?q?commits:=201.=20First=20commit=20(3af8760):=20`curl`=20?=
 =?UTF-8?q?=E2=86=92=20`wget`=20(=E2=9C=85=20correct=20fix)=202.=20Second?=
 =?UTF-8?q?=20commit=20(333b2ef):=20`wget`=20=E2=86=92=20`curl`=20(?=
 =?UTF-8?q?=E2=9D=8C=20introduced=20bug)=20The=20second=20commit=20was=20b?=
 =?UTF-8?q?ased=20on=20incorrect=20assumption=20that=20"curl=20is=20more?=
 =?UTF-8?q?=20widely=20available=20than=20wget=20in=20Docker=20images".=20?=
 =?UTF-8?q?This=20is=20false=20for=20Alpine.=20##=20Solution=20Revert=20he?=
 =?UTF-8?q?althcheck=20commands=20back=20to=20`wget`=20to=20match:=201.=20?=
 =?UTF-8?q?Alpine's=20pre-installed=20tools=202.=20Dockerfile.backend=20he?=
 =?UTF-8?q?althcheck=20(line=2068)=203.=20Docker=20and=20Kubernetes=20best?=
 =?UTF-8?q?=20practices=20##=20Testing=20=E2=9C=85=20Verified=20`wget`=20e?=
 =?UTF-8?q?xists=20in=20Alpine=20containers:=20```bash=20docker=20run=20--?=
 =?UTF-8?q?rm=20alpine:latest=20which=20wget=20#=20Output:=20/usr/bin/wget?=
 =?UTF-8?q?=20```=20=E2=9C=85=20Added=20new=20CI=20workflow=20to=20prevent?=
 =?UTF-8?q?=20regression:=20-=20`.github/workflows/pr-docker-compose-healt?=
 =?UTF-8?q?hcheck.yml`=20-=20Validates=20healthcheck=20compatibility=20wit?=
 =?UTF-8?q?h=20Alpine=20-=20Ensures=20containers=20reach=20healthy=20statu?=
 =?UTF-8?q?s=20##=20Impact=20-=20**Before**:=20Containers=20show=20(unheal?=
 =?UTF-8?q?thy),=20potential=20auto-restart=20loops=20-=20**After**:=20Con?=
 =?UTF-8?q?tainers=20show=20(healthy),=20monitoring=20systems=20happy=20-?=
 =?UTF-8?q?=20**Scope**:=20Only=20affects=20docker-compose=20deployments?=
 =?UTF-8?q?=20-=20**Breaking**:=20None=20-=20this=20is=20a=20bug=20fix=20#?=
 =?UTF-8?q?#=20References=20-=20PR=20#906:=20Original=20(incorrect)=20fix?=
 =?UTF-8?q?=20-=20Alpine=20Linux:=20https://alpinelinux.org/about/=20-=20D?=
 =?UTF-8?q?ockerfile.backend=20L68:=20Existing=20`wget`=20healthcheck=20Co?=
 =?UTF-8?q?-authored-by:=20the-dev-z=20<the-dev-z@users.noreply.github.com?=
 =?UTF-8?q?>=20Co-authored-by:=20tinkle-community=20<tinklefund@gmail.com>?=
 =?UTF-8?q?=20Co-authored-by:=20Shui=20<88711385+hzb1115@users.noreply.git?=
 =?UTF-8?q?hub.com>?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../pr-docker-compose-healthcheck.yml         | 152 ++++++++++++++++++
 docker-compose.yml                            |   4 +-
 2 files changed, 154 insertions(+), 2 deletions(-)
 create mode 100644 .github/workflows/pr-docker-compose-healthcheck.yml

diff --git a/.github/workflows/pr-docker-compose-healthcheck.yml b/.github/workflows/pr-docker-compose-healthcheck.yml
new file mode 100644
index 00000000..139477e5
--- /dev/null
+++ b/.github/workflows/pr-docker-compose-healthcheck.yml
@@ -0,0 +1,152 @@
+name: PR Docker Compose Healthcheck
+
+# 驗證 docker-compose.yml 的 healthcheck 配置在 Alpine 容器中正常工作
+on:
+  pull_request:
+    branches:
+      - main
+      - dev
+    paths:
+      - 'docker-compose.yml'
+      - 'docker/Dockerfile.backend'
+      - 'docker/Dockerfile.frontend'
+      - '.github/workflows/pr-docker-compose-healthcheck.yml'
+
+jobs:
+  healthcheck-test:
+    name: Test Docker Compose Healthcheck
+    runs-on: ubuntu-22.04
+    timeout-minutes: 10
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Create minimal .env for testing
+        run: |
+          cat > .env <<EOF
+          # Minimal config for healthcheck testing
+          NOFX_BACKEND_PORT=8080
+          NOFX_FRONTEND_PORT=3000
+          NOFX_TIMEZONE=UTC
+          DATA_ENCRYPTION_KEY=test-key-32-chars-minimum-length
+          JWT_SECRET=test-jwt-secret-minimum-32-chars
+          EOF
+
+      - name: Create minimal config.json
+        run: |
+          cat > config.json <<EOF
+          {
+            "ai_models": [],
+            "exchanges": [],
+            "traders": []
+          }
+          EOF
+
+      - name: Start services with docker compose
+        run: |
+          docker compose up -d
+          echo "✅ Services started, waiting for healthcheck..."
+
+      - name: Wait for healthcheck start_period
+        run: |
+          echo "⏳ Waiting 70 seconds for healthcheck start_period to complete..."
+          sleep 70
+
+      - name: Verify backend healthcheck
+        run: |
+          echo "🔍 Checking backend container health..."
+
+          BACKEND_HEALTH=$(docker inspect nofx-trading --format='{{.State.Health.Status}}')
+          echo "Backend health status: $BACKEND_HEALTH"
+
+          if [ "$BACKEND_HEALTH" != "healthy" ]; then
+            echo "❌ Backend container is not healthy!"
+            echo "Health status: $BACKEND_HEALTH"
+            echo ""
+            echo "Health logs:"
+            docker inspect nofx-trading --format='{{json .State.Health}}' | jq
+            echo ""
+            echo "Container logs:"
+            docker logs nofx-trading
+            exit 1
+          fi
+
+          echo "✅ Backend container is healthy"
+
+      - name: Verify frontend healthcheck
+        run: |
+          echo "🔍 Checking frontend container health..."
+
+          FRONTEND_HEALTH=$(docker inspect nofx-frontend --format='{{.State.Health.Status}}')
+          echo "Frontend health status: $FRONTEND_HEALTH"
+
+          if [ "$FRONTEND_HEALTH" != "healthy" ]; then
+            echo "❌ Frontend container is not healthy!"
+            echo "Health status: $FRONTEND_HEALTH"
+            echo ""
+            echo "Health logs:"
+            docker inspect nofx-frontend --format='{{json .State.Health}}' | jq
+            echo ""
+            echo "Container logs:"
+            docker logs nofx-frontend
+            exit 1
+          fi
+
+          echo "✅ Frontend container is healthy"
+
+      - name: Verify healthcheck commands are Alpine-compatible
+        run: |
+          echo "🔍 Verifying healthcheck commands use Alpine-compatible tools..."
+
+          # Check that docker-compose.yml uses wget (not curl)
+          if grep -q 'test:.*curl' docker-compose.yml; then
+            echo "❌ ERROR: docker-compose.yml uses 'curl' which doesn't exist in Alpine!"
+            echo ""
+            echo "Alpine Linux (used by our containers) includes 'wget' but not 'curl'."
+            echo "Please use 'wget --no-verbose --tries=1 --spider' instead."
+            exit 1
+          fi
+
+          if ! grep -q 'test:.*wget' docker-compose.yml; then
+            echo "⚠️  WARNING: No wget healthcheck found in docker-compose.yml"
+          else
+            echo "✅ Healthcheck uses Alpine-compatible 'wget' command"
+          fi
+
+      - name: Test healthcheck commands inside containers
+        run: |
+          echo "🧪 Testing healthcheck commands directly..."
+
+          # Test backend healthcheck command
+          echo "Testing backend healthcheck..."
+          docker exec nofx-trading wget --no-verbose --tries=1 --spider http://localhost:8080/api/health
+          echo "✅ Backend healthcheck command works"
+
+          # Test frontend healthcheck command
+          echo "Testing frontend healthcheck..."
+          docker exec nofx-frontend wget --no-verbose --tries=1 --spider http://127.0.0.1/health
+          echo "✅ Frontend healthcheck command works"
+
+      - name: Show container status
+        if: always()
+        run: |
+          echo "📊 Final container status:"
+          docker ps --format "table {{.Names}}\t{{.Status}}"
+
+      - name: Show logs on failure
+        if: failure()
+        run: |
+          echo "📋 Backend logs:"
+          docker logs nofx-trading
+          echo ""
+          echo "📋 Frontend logs:"
+          docker logs nofx-frontend
+
+      - name: Cleanup
+        if: always()
+        run: |
+          docker compose down -v
+          rm -f .env config.json
diff --git a/docker-compose.yml b/docker-compose.yml
index 38278f12..0fe50998 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -25,7 +25,7 @@ services:
     networks:
       - nofx-network
     healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:8080/api/health"]
+      test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:8080/api/health"]
       interval: 30s
       timeout: 10s
       retries: 3
@@ -45,7 +45,7 @@ services:
     depends_on:
       - nofx
     healthcheck:
-      test: ["CMD", "curl", "-f", "http://127.0.0.1/health"]
+      test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://127.0.0.1/health"]
       interval: 30s
       timeout: 10s
       retries: 3