mirror of
https://github.com/laoxong/nofx.git
synced 2026-06-04 01:48:22 +08:00
0xYYBB | ZYY | Bobo
36fcad03c5
## Problem PR #906 changed healthcheck commands from `wget` to `curl`, but Alpine Linux (our base image) does not include `curl` by default, causing all containers to fail healthchecks with: ``` exec: "curl": executable file not found in $PATH ``` This creates a configuration mismatch: - docker/Dockerfile.backend uses `wget` (✅ works) - docker-compose.yml uses `curl` (❌ fails) ## Root Cause Analysis Alpine Linux philosophy is minimalism: - ✅ `wget` is pre-installed (part of busybox) - ❌ `curl` requires `apk add curl` (~3MB extra) The original PR #906 made two commits: 1. First commit (3af8760): `curl` → `wget` (✅ correct fix) 2. Second commit (333b2ef): `wget` → `curl` (❌ introduced bug) The second commit was based on incorrect assumption that "curl is more widely available than wget in Docker images". This is false for Alpine. ## Solution Revert healthcheck commands back to `wget` to match: 1. Alpine's pre-installed tools 2. Dockerfile.backend healthcheck (line 68) 3. Docker and Kubernetes best practices ## Testing ✅ Verified `wget` exists in Alpine containers: ```bash docker run --rm alpine:latest which wget # Output: /usr/bin/wget ``` ✅ Added new CI workflow to prevent regression: - `.github/workflows/pr-docker-compose-healthcheck.yml` - Validates healthcheck compatibility with Alpine - Ensures containers reach healthy status ## Impact - **Before**: Containers show (unhealthy), potential auto-restart loops - **After**: Containers show (healthy), monitoring systems happy - **Scope**: Only affects docker-compose deployments - **Breaking**: None - this is a bug fix ## References - PR #906: Original (incorrect) fix - Alpine Linux: https://alpinelinux.org/about/ - Dockerfile.backend L68: Existing `wget` healthcheck Co-authored-by: the-dev-z <the-dev-z@users.noreply.github.com> Co-authored-by: tinkle-community <tinklefund@gmail.com> Co-authored-by: Shui <88711385+hzb1115@users.noreply.github.com>
56 lines
1.7 KiB
YAML
56 lines
1.7 KiB
YAML
services:
|
||
# Backend service (API and core logic)
|
||
nofx:
|
||
build:
|
||
context: .
|
||
dockerfile: ./docker/Dockerfile.backend
|
||
container_name: nofx-trading
|
||
restart: unless-stopped
|
||
stop_grace_period: 30s # 允许应用有 30 秒时间优雅关闭
|
||
ports:
|
||
- "${NOFX_BACKEND_PORT:-8080}:8080"
|
||
volumes:
|
||
- ./config.json:/app/config.json:ro
|
||
- ./config.db:/app/config.db
|
||
- ./beta_codes.txt:/app/beta_codes.txt:ro
|
||
- ./decision_logs:/app/decision_logs
|
||
- ./prompts:/app/prompts
|
||
- ./secrets:/app/secrets:ro # RSA密钥文件
|
||
- /etc/localtime:/etc/localtime:ro # Sync host time
|
||
environment:
|
||
- TZ=${NOFX_TIMEZONE:-Asia/Shanghai} # Set timezone
|
||
- AI_MAX_TOKENS=4000 # AI响应的最大token数（默认2000，建议4000-8000）
|
||
- DATA_ENCRYPTION_KEY=${DATA_ENCRYPTION_KEY} # 数据库加密密钥
|
||
- JWT_SECRET=${JWT_SECRET} # JWT认证密钥
|
||
networks:
|
||
- nofx-network
|
||
healthcheck:
|
||
test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:8080/api/health"]
|
||
interval: 30s
|
||
timeout: 10s
|
||
retries: 3
|
||
start_period: 60s
|
||
|
||
# Frontend service (static serving and proxy)
|
||
nofx-frontend:
|
||
build:
|
||
context: .
|
||
dockerfile: ./docker/Dockerfile.frontend
|
||
container_name: nofx-frontend
|
||
restart: unless-stopped
|
||
ports:
|
||
- "${NOFX_FRONTEND_PORT:-3000}:80"
|
||
networks:
|
||
- nofx-network
|
||
depends_on:
|
||
- nofx
|
||
healthcheck:
|
||
test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://127.0.0.1/health"]
|
||
interval: 30s
|
||
timeout: 10s
|
||
retries: 3
|
||
start_period: 5s
|
||
|
||
networks:
|
||
nofx-network:
|
||
driver: bridge |