mirror of
https://github.com/laoxong/nofx.git
synced 2026-06-04 09:58:22 +08:00
0c1f438cc3
* fix: improve trader error handling and balance validation * fix: localize structured trader failure reasons --------- Co-authored-by: apple <apple@MacbookPro-zbh.local>
127 lines
3.6 KiB
Go
127 lines
3.6 KiB
Go
package api
|
|
|
|
import (
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"nofx/logger"
|
|
)
|
|
|
|
type APIErrorResponse struct {
|
|
Error string `json:"error"`
|
|
ErrorKey string `json:"error_key,omitempty"`
|
|
ErrorParams map[string]string `json:"error_params,omitempty"`
|
|
}
|
|
|
|
func writeAPIError(c *gin.Context, statusCode int, publicMsg, errorKey string, errorParams map[string]string) {
|
|
resp := APIErrorResponse{
|
|
Error: publicMsg,
|
|
}
|
|
if errorKey != "" {
|
|
resp.ErrorKey = errorKey
|
|
}
|
|
if len(errorParams) > 0 {
|
|
resp.ErrorParams = errorParams
|
|
}
|
|
c.JSON(statusCode, resp)
|
|
}
|
|
|
|
// SafeError returns a safe error message without exposing internal details
|
|
// It logs the actual error for debugging but returns a generic message to the client
|
|
func SafeError(c *gin.Context, statusCode int, publicMsg string, internalErr error) {
|
|
// Log the actual error internally
|
|
if internalErr != nil {
|
|
logger.Errorf("[API Error] %s: %v", publicMsg, internalErr)
|
|
}
|
|
|
|
writeAPIError(c, statusCode, publicMsg, "", nil)
|
|
}
|
|
|
|
func SafeErrorWithDetails(c *gin.Context, statusCode int, publicMsg, errorKey string, errorParams map[string]string, internalErr error) {
|
|
if internalErr != nil {
|
|
logger.Errorf("[API Error] %s: %v", publicMsg, internalErr)
|
|
}
|
|
|
|
writeAPIError(c, statusCode, publicMsg, errorKey, errorParams)
|
|
}
|
|
|
|
// SafeInternalError logs internal error and returns a generic message
|
|
func SafeInternalError(c *gin.Context, operation string, err error) {
|
|
logger.Errorf("[Internal Error] %s: %v", operation, err)
|
|
writeAPIError(c, http.StatusInternalServerError, operation+" failed", "", nil)
|
|
}
|
|
|
|
// SafeBadRequest returns a safe bad request error
|
|
// For validation errors, we can be more specific since they're about user input
|
|
func SafeBadRequest(c *gin.Context, msg string) {
|
|
writeAPIError(c, http.StatusBadRequest, msg, "", nil)
|
|
}
|
|
|
|
func SafeBadRequestWithDetails(c *gin.Context, msg, errorKey string, errorParams map[string]string) {
|
|
writeAPIError(c, http.StatusBadRequest, msg, errorKey, errorParams)
|
|
}
|
|
|
|
// SafeNotFound returns a generic not found error
|
|
func SafeNotFound(c *gin.Context, resource string) {
|
|
writeAPIError(c, http.StatusNotFound, resource+" not found", "", nil)
|
|
}
|
|
|
|
// SafeUnauthorized returns unauthorized error
|
|
func SafeUnauthorized(c *gin.Context) {
|
|
writeAPIError(c, http.StatusUnauthorized, "Unauthorized", "", nil)
|
|
}
|
|
|
|
// SafeForbidden returns forbidden error
|
|
func SafeForbidden(c *gin.Context, msg string) {
|
|
writeAPIError(c, http.StatusForbidden, msg, "", nil)
|
|
}
|
|
|
|
// IsSensitiveError checks if an error message contains sensitive information
|
|
func IsSensitiveError(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
errMsg := strings.ToLower(err.Error())
|
|
|
|
sensitivePatterns := []string{
|
|
// Database
|
|
"postgres", "mysql", "sqlite", "database", "sql",
|
|
"connection", "connect", "failed to connect",
|
|
// Network
|
|
"dial", "tcp", "udp", "socket", "timeout",
|
|
// Server info
|
|
"127.0.0.1", "localhost", "0.0.0.0",
|
|
// File system
|
|
"no such file", "permission denied", "open /",
|
|
// Credentials
|
|
"password", "user=", "host=", "port=",
|
|
// Internal
|
|
"panic", "runtime error", "stack trace",
|
|
}
|
|
|
|
for _, pattern := range sensitivePatterns {
|
|
if strings.Contains(errMsg, pattern) {
|
|
return true
|
|
}
|
|
}
|
|
|
|
// Check for IP addresses (simple pattern)
|
|
if strings.Contains(errMsg, ":") && (strings.Contains(errMsg, ".") || strings.Contains(errMsg, "::")) {
|
|
return true
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// SanitizeError returns the error message if safe, otherwise returns a generic message
|
|
func SanitizeError(err error, fallbackMsg string) string {
|
|
if err == nil {
|
|
return fallbackMsg
|
|
}
|
|
if IsSensitiveError(err) {
|
|
return fallbackMsg
|
|
}
|
|
return err.Error()
|
|
}
|