mirror of
https://github.com/laoxong/nofx.git
synced 2026-06-07 11:17:56 +08:00
SkywalkerJi
117 lines
2.0 KiB
Markdown
117 lines
2.0 KiB
Markdown
# Pull Request - Backend
|
|
|
|
> **💡 Tip:** Recommended PR title format `type(scope): description`
|
|
> Example: `feat(trader): add new strategy` | `fix(api): resolve auth issue`
|
|
|
|
---
|
|
|
|
## 📝 Description
|
|
|
|
|
|
|
|
---
|
|
|
|
## 🎯 Type of Change
|
|
|
|
- [ ] 🐛 Bug fix
|
|
- [ ] ✨ New feature
|
|
- [ ] 💥 Breaking change
|
|
- [ ] ♻️ Refactoring
|
|
- [ ] ⚡ Performance improvement
|
|
- [ ] 🔒 Security fix
|
|
- [ ] 🔧 Build/config change
|
|
|
|
---
|
|
|
|
## 🔗 Related Issues
|
|
|
|
- Closes #
|
|
- Related to #
|
|
|
|
---
|
|
|
|
## 📋 Changes Made
|
|
|
|
-
|
|
-
|
|
|
|
---
|
|
|
|
## 🧪 Testing
|
|
|
|
### Test Environment
|
|
- **OS:**
|
|
- **Go Version:**
|
|
- **Exchange:** [if applicable]
|
|
|
|
### Manual Testing
|
|
- [ ] Tested locally
|
|
- [ ] Tested on testnet (for exchange integration)
|
|
- [ ] Unit tests pass
|
|
- [ ] Verified no existing functionality broke
|
|
|
|
### Test Results
|
|
```
|
|
Test output here
|
|
```
|
|
|
|
---
|
|
|
|
## 🔒 Security Considerations
|
|
|
|
- [ ] No API keys or secrets hardcoded
|
|
- [ ] User inputs properly validated
|
|
- [ ] No SQL injection vulnerabilities
|
|
- [ ] Authentication/authorization properly handled
|
|
- [ ] Sensitive data is encrypted
|
|
- [ ] N/A (not security-related)
|
|
|
|
---
|
|
|
|
## ⚡ Performance Impact
|
|
|
|
- [ ] No significant performance impact
|
|
- [ ] Performance improved
|
|
- [ ] Performance may be impacted (explain below)
|
|
|
|
**If impacted, explain:**
|
|
|
|
|
|
---
|
|
|
|
## ✅ Checklist
|
|
|
|
### Code Quality
|
|
- [ ] Code follows project style
|
|
- [ ] Self-review completed
|
|
- [ ] Comments added for complex logic
|
|
- [ ] Code compiles successfully (`go build`)
|
|
- [ ] Ran `go fmt`
|
|
|
|
### Documentation
|
|
- [ ] Updated relevant documentation
|
|
- [ ] Added inline comments where necessary
|
|
- [ ] Updated API documentation (if applicable)
|
|
|
|
### Git
|
|
- [ ] Commits follow conventional format
|
|
- [ ] Rebased on latest `dev` branch
|
|
- [ ] No merge conflicts
|
|
|
|
---
|
|
|
|
## 📚 Additional Notes
|
|
|
|
|
|
---
|
|
|
|
**By submitting this PR, I confirm:**
|
|
|
|
- [ ] I have read the [Contributing Guidelines](../../CONTRIBUTING.md)
|
|
- [ ] I agree to the [Code of Conduct](../../CODE_OF_CONDUCT.md)
|
|
- [ ] My contribution is licensed under AGPL-3.0
|
|
|
|
---
|
|
|
|
🌟 **Thank you for your contribution!**
|